Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #28 #49

Merged
merged 1 commit into from
Mar 22, 2025
Merged

Fixed #28 #49

merged 1 commit into from
Mar 22, 2025

Conversation

ACE07-Sev
Copy link
Member

Closes #28

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.10% (target: -1.00%) 91.03%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (93bba85) 4160 3693 88.77%
Head commit (71c1d27) 4216 (+56) 3747 (+54) 88.88% (+0.10%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#49) 78 71 91.03%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Mar 22, 2025

Codecov Report

Attention: Patch coverage is 91.02564% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.87%. Comparing base (93bba85) to head (71c1d27).
Report is 2 commits behind head on 0.0.0-release.

Files with missing lines Patch % Lines
quick/circuit/circuit.py 88.00% 3 Missing ⚠️
quick/circuit/dag/dagnode.py 90.62% 3 Missing ⚠️
quick/circuit/dag/dagcircuit.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           0.0.0-release      #49      +/-   ##
=================================================
+ Coverage          88.77%   88.87%   +0.10%     
=================================================
  Files                 61       61              
  Lines               4160     4216      +56     
=================================================
+ Hits                3693     3747      +54     
- Misses               467      469       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ACE07-Sev
Copy link
Member Author

The implementation is based on DAG equivalency. If you are seeing this in the future, please reopen this ticket and paste your example which has caused a false True or False.

@ACE07-Sev ACE07-Sev merged commit 647bce0 into 0.0.0-release Mar 22, 2025
10 of 11 checks passed
@ACE07-Sev ACE07-Sev deleted the circuit-eq-fix branch March 22, 2025 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant