Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/CD modification #10

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

CI/CD modification #10

wants to merge 4 commits into from

Conversation

ACE07-Sev
Copy link
Member

  • Moved py.typed back into root.
  • Renamed .yaml to .yml for consistency.
  • Added os matrix to tests.yml.

- Moved py.typed back into root.
- Renamed .yaml to .yml for consistency.
- Added os matrix to tests.yml.
@ACE07-Sev
Copy link
Member Author

ACE07-Sev commented Dec 26, 2024

So, mac os seems to be having some floating point errors. Have to fix that for consistency. Temporarily removed macos to identity other potential issues.

@ACE07-Sev ACE07-Sev self-assigned this Dec 26, 2024
@ACE07-Sev ACE07-Sev added the github_actions Pull requests that update GitHub Actions code label Dec 26, 2024
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.95%. Comparing base (737efa1) to head (81c6261).
Report is 26 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
- Coverage   86.97%   86.95%   -0.02%     
==========================================
  Files          55       55              
  Lines        3831     3856      +25     
==========================================
+ Hits         3332     3353      +21     
- Misses        499      503       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codacy-production bot commented Dec 26, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for be352f91
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (be352f9) Report Missing Report Missing Report Missing
Head commit (81c6261) 3856 3353 86.96%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#10) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@ACE07-Sev
Copy link
Member Author

Issue with macos and windows failing is due to the floating error in weyl.py. Line 243 requires a very precise input, and slightest inaccuracy in decimal points potentially causes wrong results. This will be addressed with an alternate implementation in the next major release.

In the meantime, I will move forward with the other items.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant