Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Coverage and Testing. #715

Merged
merged 6 commits into from
Oct 16, 2023
Merged

Split Coverage and Testing. #715

merged 6 commits into from
Oct 16, 2023

Conversation

weinbe58
Copy link
Member

Currently there seems to be an issue where sometimes code coverage will fail to upload which will cause the whole CI to fail. I would like to split this apart because means we have to run the CI all over again even though there are not any issues with the tests.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 16, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-10-16 14:43 UTC

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #715 (52253a1) into main (608793d) will decrease coverage by 0.04%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   85.42%   85.38%   -0.04%     
==========================================
  Files          89       89              
  Lines        7566     7563       -3     
==========================================
- Hits         6463     6458       -5     
- Misses       1103     1105       +2     
Files Coverage Δ
src/bloqade/constants.py 100.00% <100.00%> (ø)
src/bloqade/factory.py 100.00% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weinbe58 weinbe58 merged commit 2b3c0aa into main Oct 16, 2023
9 checks passed
@weinbe58 weinbe58 deleted the split-covergage-and-ci branch October 16, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant