Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rydberg h factory #652

Merged
merged 16 commits into from
Sep 29, 2023
Merged

Rydberg h factory #652

merged 16 commits into from
Sep 29, 2023

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Sep 29, 2023

  • moving the factory to top level of package
  • adding sample method to PythonFn node
  • adding unit test for rydberg_h implementation.

@weinbe58 weinbe58 linked an issue Sep 29, 2023 that may be closed by this pull request
2 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Sep 29, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-29 15:18 UTC

@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

Merging #652 (077a42e) into main (541c2fe) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head 077a42e differs from pull request most recent head 60570c2. Consider uploading reports for the commit 60570c2 to get more accurate results

@@            Coverage Diff             @@
##             main     #652      +/-   ##
==========================================
+ Coverage   84.57%   84.71%   +0.14%     
==========================================
  Files          89       89              
  Lines        7376     7379       +3     
==========================================
+ Hits         6238     6251      +13     
+ Misses       1138     1128      -10     
Files Coverage Δ
src/bloqade/__init__.py 100.00% <100.00%> (ø)
src/bloqade/builder/assign.py 100.00% <100.00%> (ø)
src/bloqade/factory.py 100.00% <100.00%> (ø)
src/bloqade/ir/__init__.py 100.00% <ø> (ø)
src/bloqade/ir/control/waveform.py 88.04% <100.00%> (+0.11%) ⬆️

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weinbe58 weinbe58 enabled auto-merge (squash) September 29, 2023 15:14
@weinbe58 weinbe58 merged commit ce1cb35 into main Sep 29, 2023
@weinbe58 weinbe58 deleted the rydberg-h-factory branch September 29, 2023 15:15
weinbe58 added a commit that referenced this pull request Sep 29, 2023
@weinbe58 weinbe58 restored the rydberg-h-factory branch September 29, 2023 16:04
weinbe58 added a commit that referenced this pull request Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: rydberg_h as a factory function
2 participants