Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch assign list and dict #640

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Batch assign list and dict #640

merged 6 commits into from
Sep 27, 2023

Conversation

weinbe58
Copy link
Member

allow batch_assign to take both a list of dictionaries or a dictionary of lists preserving old API.

@weinbe58 weinbe58 linked an issue Sep 27, 2023 that may be closed by this pull request
@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-27 17:16 UTC

@weinbe58 weinbe58 requested a review from johnzl-777 September 27, 2023 15:09
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #640 (33b2070) into main (ff34690) will increase coverage by 0.08%.
The diff coverage is 96.20%.

@@            Coverage Diff             @@
##             main     #640      +/-   ##
==========================================
+ Coverage   83.36%   83.44%   +0.08%     
==========================================
  Files          89       89              
  Lines        7321     7340      +19     
==========================================
+ Hits         6103     6125      +22     
+ Misses       1218     1215       -3     
Files Coverage Δ
src/bloqade/builder/assign.py 100.00% <100.00%> (+8.19%) ⬆️
src/bloqade/builder/parse/builder.py 97.29% <100.00%> (-0.03%) ⬇️
src/bloqade/ir/location/list.py 95.00% <100.00%> (+0.12%) ⬆️
src/bloqade/ir/scalar.py 88.78% <90.00%> (-0.14%) ⬇️
src/bloqade/builder/pragmas.py 85.18% <80.00%> (-1.78%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@johnzl-777 johnzl-777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Nice

@johnzl-777 johnzl-777 merged commit cb429e2 into main Sep 27, 2023
9 checks passed
@johnzl-777 johnzl-777 deleted the batch-assign-list-and-dict branch September 27, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

batch_assign: Dict[List] vs List[Dict]
2 participants