Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ir printing #629

Merged
merged 39 commits into from
Sep 28, 2023
Merged

Fixing ir printing #629

merged 39 commits into from
Sep 28, 2023

Conversation

weinbe58
Copy link
Member

going back to the standard definitions for printing e.g. repr is python code and str is a prettier version of the object.

I understand this won't fix the issue with the python REPL looks bad for the IR but it looks even worse when you have objects that use the standard convention while the bloqade IR objects do not. I think its looks better if things are consistent.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-28 15:51 UTC

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #629 (e82003f) into main (ab5ec51) will increase coverage by 0.95%.
Report is 2 commits behind head on main.
The diff coverage is 84.72%.

❗ Current head e82003f differs from pull request most recent head f3e0fd8. Consider uploading reports for the commit f3e0fd8 to get more accurate results

@@            Coverage Diff             @@
##             main     #629      +/-   ##
==========================================
+ Coverage   83.44%   84.40%   +0.95%     
==========================================
  Files          89       89              
  Lines        7335     7349      +14     
==========================================
+ Hits         6121     6203      +82     
+ Misses       1214     1146      -68     
Files Coverage Δ
src/bloqade/builder/parse/trait.py 80.00% <100.00%> (+5.58%) ⬆️
src/bloqade/codegen/common/json.py 66.07% <ø> (ø)
src/bloqade/codegen/hardware/quera.py 92.28% <100.00%> (ø)
src/bloqade/emulate/ir/atom_type.py 95.23% <100.00%> (+7.60%) ⬆️
src/bloqade/emulate/ir/space.py 98.60% <100.00%> (+28.45%) ⬆️
src/bloqade/emulate/sparse_operator.py 71.42% <100.00%> (+19.99%) ⬆️
src/bloqade/ir/analysis/assignment_scan.py 94.80% <100.00%> (ø)
src/bloqade/ir/location/bravais.py 93.72% <100.00%> (-0.90%) ⬇️
src/bloqade/ir/location/list.py 95.34% <100.00%> (+0.34%) ⬆️
src/bloqade/visualization/ir_visualize.py 76.43% <100.00%> (ø)
... and 14 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weinbe58 weinbe58 marked this pull request as draft September 25, 2023 14:43
@weinbe58 weinbe58 marked this pull request as ready for review September 25, 2023 15:23
@weinbe58 weinbe58 merged commit a60fb8e into main Sep 28, 2023
6 checks passed
@weinbe58 weinbe58 deleted the fixing-IR-printing branch September 28, 2023 15:48
@weinbe58 weinbe58 added the triage requires triage meeting decision label Sep 28, 2023
@weinbe58 weinbe58 removed the triage requires triage meeting decision label Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant