Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing more bugs in emulator. #614

Merged
merged 18 commits into from
Sep 25, 2023
Merged

Fixing more bugs in emulator. #614

merged 18 commits into from
Sep 25, 2023

Conversation

weinbe58
Copy link
Member

@weinbe58 weinbe58 commented Sep 21, 2023

  1. Detuning operator had the wrong sign
  2. Rabi amplitude was missing a factor of 1/2
  3. Added a KS test to check of the empirical distributions generated by bloqade and braket are statistically the same.
  4. Adding testss for emulator IR code generation.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2023

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-09-25 14:59 UTC

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #614 (3a92e29) into main (88be4f1) will increase coverage by 0.17%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
+ Coverage   83.12%   83.30%   +0.17%     
==========================================
  Files          88       89       +1     
  Lines        7285     7312      +27     
==========================================
+ Hits         6056     6091      +35     
+ Misses       1229     1221       -8     
Files Changed Coverage Δ
src/bloqade/codegen/common/is_hyperfine.py 85.00% <85.00%> (ø)
src/bloqade/codegen/emulator_ir.py 94.16% <93.33%> (+3.32%) ⬆️
src/bloqade/emulate/codegen/hamiltonian.py 88.13% <100.00%> (+3.38%) ⬆️
src/bloqade/emulate/ir/state_vector.py 76.39% <100.00%> (ø)
src/bloqade/task/batch.py 68.39% <100.00%> (+0.13%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@weinbe58 weinbe58 requested a review from Roger-luo September 21, 2023 18:38
@Roger-luo
Copy link
Member

haven't looked into the detailed implementation, I'll do another review tmr

@weinbe58 weinbe58 requested a review from Roger-luo September 23, 2023 12:45
@weinbe58 weinbe58 merged commit 4c72a23 into main Sep 25, 2023
@weinbe58 weinbe58 deleted the emulator-fixing-detuning branch September 25, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integration tests to validate the correctness of the solutions generated by the entire pipeline.
2 participants