Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add value and key in Variable response #503

Merged
merged 2 commits into from
Nov 14, 2023
Merged

fix: add value and key in Variable response #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c35cf95
fix: add value and key in Variable response
pggb25 Nov 14, 2023
980b05f
set value as required and nullable
pggb25 Nov 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/schemas/variable/VariableResponse.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,14 @@ allOf:
- type: object
required:
- scope
- key
- value
properties:
key:
type: string
value:
type: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we say value is required but can be nullable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can try.

nullable: true
overridden_variable:
$ref: './VariableOverride.yaml'
aliased_variable:
Expand Down
Loading