Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(git-tokens): preserve previous params order #482

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Oct 25, 2023

TS generated client relies on params declaration order to generate function like func(param1, param2).
So order MUST be preserved even if this is named param.

TS generated client relies on params declaration order to generate
function like `func(param1, param2)`. So order MUST be preserved even if
this is named param.
@ctjhoa ctjhoa added the bug Something isn't working label Oct 25, 2023
@ctjhoa ctjhoa merged commit be5b92c into main Oct 25, 2023
9 of 10 checks passed
@ctjhoa ctjhoa deleted the fix_git_token_params branch October 25, 2023 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants