feat: add metrics in Stage and Service Status #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pggb25
force-pushed
the
feat/time-info
branch
3 times, most recently
from
2cb1d9a
to
4e26828
Compare
pggb25
force-pushed
the
feat/time-info
branch
from
4e26828
to
77ef692
Compare
acarranoqovery
approved these changes
Sep 11, 2023
| @@ -0,0 +1,16 @@ | |||
| type: string | |||
| enum: | |||
| - TOTAL | |||
There was a problem hiding this comment.
what if we move the "total" as a field instead of a metric? it would avoid to look for the right element and have a "detail" field with all the info
"stage":{
"id": "9h93h9rfh9h3hr"
"name":"stage"
"state": SUCCESS
"metrics": {
"total_time": 10s,
"detail":[
{
"step_name": "PROVISION_BUILDER",
"status": "SUCCESS",
"duration_sec": 14
},
...
]
}
}
There was a problem hiding this comment.
same on the app side. the "state" assigned to the TOTAL step can't be different from the "state" of the app . So I don't think it's a good idea to have the "Total" as an object in a metric array
…may not be set if the deployment is not completed yet. Possible for the Web Socket use case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.