Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(audit-logs): add last entry placeholder #1508

Open
wants to merge 8 commits into
base: staging
Choose a base branch
from

Conversation

RemiBonnet
Copy link
Member

@RemiBonnet RemiBonnet commented Jul 23, 2024

What does this PR do?

https://qovery.atlassian.net/jira/software/projects/FRT/boards/23?selectedIssue=FRT-1188

Screenshot 2024-07-23 at 16 29 43

PR Checklist

  • This PR introduces breaking change(s) and has been labeled as such
  • This PR introduces new store changes
  • I have followed the library pattern i.e feature, ui, data, utils
  • I made sure the code is type safe (no any)

@RemiBonnet
Copy link
Member Author

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Take rest sometimes

Copy link

nx-cloud bot commented Jul 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5c9e127. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

<div className="flex h-14 items-center justify-center border-b border-neutral-200">
<p className="flex gap-1 text-sm text-neutral-400">
{auditLogsRetentionInDays} days limit reached.
{/* TODO: add a real button */}
Copy link
Member Author

@RemiBonnet RemiBonnet Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RemiBonnet RemiBonnet marked this pull request as ready for review July 23, 2024 14:32
@RemiBonnet RemiBonnet requested a review from ctjhoa July 23, 2024 14:59
Copy link

codecov bot commented Jul 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 45.48%. Comparing base (f120833) to head (5c9e127).

Files with missing lines Patch % Lines
...es/events/src/lib/ui/page-general/page-general.tsx 57.89% 5 Missing and 3 partials ⚠️

❗ There is a different number of reports uploaded between BASE (f120833) and HEAD (5c9e127). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f120833) HEAD (5c9e127)
unittests 2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #1508      +/-   ##
===========================================
- Coverage    53.15%   45.48%   -7.67%     
===========================================
  Files          961       15     -946     
  Lines        12933      288   -12645     
  Branches      3718       95    -3623     
===========================================
- Hits          6874      131    -6743     
+ Misses        4792      128    -4664     
+ Partials      1267       29    -1238     
Flag Coverage Δ
unittests 45.48% <60.00%> (-7.67%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RemiBonnet RemiBonnet removed the request for review from ctjhoa July 29, 2024 07:36
@RemiBonnet RemiBonnet force-pushed the feat/audit-logs-last-entry-FRT-1188 branch from 2f388f6 to 2106afd Compare September 13, 2024 07:01
@RemiBonnet RemiBonnet force-pushed the feat/audit-logs-last-entry-FRT-1188 branch from 2106afd to 58dba76 Compare October 3, 2024 15:56
@RemiBonnet RemiBonnet force-pushed the feat/audit-logs-last-entry-FRT-1188 branch from 58dba76 to 5c9e127 Compare October 15, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant