Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add tanstack/router #1141

Draft
wants to merge 9 commits into
base: staging
Choose a base branch
from
Draft

chore: add tanstack/router #1141

wants to merge 9 commits into from

Conversation

ctjhoa
Copy link
Contributor

@ctjhoa ctjhoa commented Jan 22, 2024

What does this PR do?

This PR adds @tanstack/router in conjunction with react-router-dom.

This PR is currently blocked by this bug

Current state:

  • react-router -> tanstack-router = OK
  • tanstack-router -> react-router = KO

There is an issue to migrate incrementally from react-router to tanstack/router.
When doing transitions like react-router -> tanstack/router -> react-router, tanstack router go into the defaultNotFoundComponent state during the last transition.
There don't seems to be a way to reset that internal state in tanstack router, so tanstack router is stuck on login page.

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 28102cd2-684e-4ecb-a4f7-2f37f653b027 my-helm-env
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Truth can only be found in one place: the code

@RemiBonnet
Copy link
Member

Qovery Preview

A preview environment was automatically created via Qovery.
Click on the link below to follow its deployment and use it.
👉 [PR] my-env - chore: add tanstack/router - 2024-01-22T13:21:44Z

Another comment will be posted when deployments are terminated

Copy link

nx-cloud bot commented Jan 22, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 891ff45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

@RemiBonnet
Copy link
Member

Qovery Preview

Your preview environment failed to be deployed !
Click on the link below to check the deployment logs.
👉 [PR] my-env - chore: add tanstack/router - 2024-01-22T13:21:44Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants