-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add tanstack/router #1141
base: staging
Are you sure you want to change the base?
Conversation
Qovery can create a Preview Environment for this PR.
This comment has been generated from Qovery AI 🤖.
|
A preview environment was automatically created via Qovery. Another comment will be posted when deployments are terminated |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 891ff45. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targetsSent with 💌 from NxCloud. |
Your preview environment failed to be deployed ! |
What does this PR do?
This PR adds
@tanstack/router
in conjunction withreact-router-dom
.This PR is currently blocked by this bugCurrent state:
There is an issue to migrate incrementally from react-router to tanstack/router.
When doing transitions like react-router -> tanstack/router -> react-router, tanstack router go into the defaultNotFoundComponent state during the last transition.
There don't seems to be a way to reset that internal state in tanstack router, so tanstack router is stuck on login page.