Skip to content
This repository has been archived by the owner on Aug 13, 2024. It is now read-only.

feat: add detailed view and show logs #18

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

Tchoupinax
Copy link
Contributor

@Tchoupinax Tchoupinax commented Jul 24, 2024

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

What does this PR do?

Description

Following the runs history, this merge request brings the "details" view, with status and logs.

Screenshot

image


PR Checklist

Global

  • I have performed a self-review of my code

Clean Code

  • I made sure the code is type safe (no any)
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation

Type of Change (commit types)

The appropriate commit types in your PR are required. See a table of them below

Commit Type Title Description Emoji
feat Features A new feature (something new that impacts the end-user)
fix Bug Fixes A bug Fix 🐛
docs Documentation Documentation only changes 📚
style Styles Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc) 💎
refactor Code Refactoring A code change that neither fixes a bug nor adds a feature 📦
perf Performance Improvements A code change that improves performance 🚀
test Tests Adding missing tests or correcting existing tests 🚨
build Builds Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm) 🛠
ci Continuous Integrations Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs) ⚙️
chore Chores Other changes that don't modify src or test files ♻️
revert Reverts Reverts a previous commit 🗑

@Tchoupinax Tchoupinax changed the title Feature/details view feat: add detailed view Jul 24, 2024
@Tchoupinax Tchoupinax marked this pull request as draft July 24, 2024 21:33
Copy link

gitguardian bot commented Jul 25, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
10273821 Triggered Generic Password 34deeb8 docker-compose-dev.yaml View secret
10273821 Triggered Generic Password 27689af docker-compose.dev.yaml View secret
10273821 Triggered Generic Password a9d87d6 docker-compose-dev.yaml View secret
10273821 Triggered Generic Password 8fbeda1 docker-compose.dev.yaml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Tchoupinax
Copy link
Contributor Author

It should be rebased until #9 is merged

@@ -85,6 +85,18 @@ self_service:
- bash
- examples/dumb_script_ok.sh # AND then this one
output_model: string (optional) # model name
- slug: get-temperature-paris
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a POC with Node.js

@Tchoupinax Tchoupinax changed the title feat: add detailed view feat: add detailed view and show logs Jul 25, 2024
@Tchoupinax Tchoupinax requested a review from evoxmusic July 25, 2024 18:52
@Tchoupinax
Copy link
Contributor Author

Hello @evoxmusic,
I made the first version of the detailed view, it resumes the state of the run and show stores logs.

I am not a rust expert so if you see bad practices I would be happy to change them!

Have a nice day,

@Tchoupinax Tchoupinax marked this pull request as ready for review July 25, 2024 18:56
@Tchoupinax Tchoupinax self-assigned this Jul 25, 2024
@Tchoupinax Tchoupinax added the enhancement New feature or request label Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant