Add benchmark + improve performance #257
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 8, 2023
|
How far along is this upgrade? We just tried using Replibyte and found it to be very slow at the moment. |
|
I built off of this branch hoping the performance would be improved. Unfortunately it was the same, if not worse. When creating a dump, it'll progress at 22Mib/min. It DOES however, seem to fix the "getting killed after 300Mb bug", so might still be worth merging for that alone |
|
hi, is there any news on performance improvements ? It"s actually difficult to create a dump in a reasonable time and without memory issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to add benchmark and improve tokeniser and subset performances