Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt #2

Open
wants to merge 1 commit into
base: cmake
Choose a base branch
from
Open

Update CMakeLists.txt #2

wants to merge 1 commit into from

Conversation

h1z1
Copy link

@h1z1 h1z1 commented Aug 29, 2020

SDL build defaults to ON but can fail to be detected at build. examples/imgui_impl_sdl.cmake will fail as a result.

Option comment implies the build would succeed only if detected. Make it a fatal error for now.

[ 57%] Building CXX object CMakeFiles/imgui-sdl.dir/examples/imgui_impl_sdl.cpp.o
/tmp/build/imgui-cmake/examples/imgui_impl_sdl.cpp:51:17: fatal error: SDL.h: No such file or directory
 #include <SDL.h>
                 ^
compilation terminated.
[ 71%] Built target imgui_example_glut_opengl2
[ 85%] Built target imgui_example_null
make[2]: *** [CMakeFiles/imgui-sdl.dir/examples/imgui_impl_sdl.cpp.o] Error 1
make[1]: *** [CMakeFiles/imgui-sdl.dir/all] Error 2
make: *** [all] Error 2
$

SDL build defaults to ON but can fail to be detected at build.  examples/imgui_impl_sdl.cmake will fail as a result.  

Option comment implies the build would succeed only if detected.  Make it a fatal error for now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant