Skip to content

enhance visualization func type hint #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 11, 2025

Conversation

zen-xu
Copy link
Contributor

@zen-xu zen-xu commented May 8, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 8, 2025

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@IvanIsCoding
Copy link
Collaborator

Thanks for your second contribution to rustworkx!

I will need to review this PR with more care. In the meantime @zen-xu can you sign the CLA? Otherwise we won't be able to merge your code. Thanks.

@coveralls
Copy link

coveralls commented May 9, 2025

Pull Request Test Coverage Report for Build 14953556689

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 95.236%

Files with Coverage Reduction New Missed Lines %
rustworkx-core/src/token_swapper.rs 5 97.0%
Totals Coverage Status
Change from base Build 14916993103: 0.0%
Covered Lines: 18733
Relevant Lines: 19670

💛 - Coveralls

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The matplotlib change LGTM, for graphviz I'd rather not step into using typing.Literal. The typing.overload is fine.

@IvanIsCoding IvanIsCoding enabled auto-merge May 10, 2025 03:46
auto-merge was automatically disabled May 10, 2025 03:51

Head branch was pushed to by a user without write access

@zen-xu zen-xu force-pushed the enhance-visualization-typing branch from 86943de to 6076d8d Compare May 10, 2025 03:51
@IvanIsCoding
Copy link
Collaborator

I think you’ll need to run the code formatter. Either nox -eblack or just black rustworkx if you have it installed

@IvanIsCoding IvanIsCoding added this pull request to the merge queue May 11, 2025
Merged via the queue into Qiskit:main with commit 30897c5 May 11, 2025
31 checks passed
@zen-xu zen-xu deleted the enhance-visualization-typing branch May 11, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants