-
Notifications
You must be signed in to change notification settings - Fork 179
enhance visualization func type hint #1443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance visualization func type hint #1443
Conversation
|
Thanks for your second contribution to rustworkx! I will need to review this PR with more care. In the meantime @zen-xu can you sign the CLA? Otherwise we won't be able to merge your code. Thanks. |
Signed-off-by: ZhengYu, Xu <[email protected]>
Pull Request Test Coverage Report for Build 14953556689Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
…workx into enhance-visualization-typing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The matplotlib change LGTM, for graphviz I'd rather not step into using typing.Literal
. The typing.overload
is fine.
Head branch was pushed to by a user without write access
86943de
to
6076d8d
Compare
I think you’ll need to run the code formatter. Either |
No description provided.