-
Notifications
You must be signed in to change notification settings - Fork 179
Use dependency groups in CI #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@@ -63,10 +63,13 @@ name = "Ivan Carvalho" | |||
email = "[email protected]" | |||
|
|||
[build-system] | |||
requires = ["setuptools>=70.1.0", "setuptools-rust>=1.9"] | |||
requires = ["setuptools>=77.0.0", "setuptools-rust>=1.9"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is something I overlooked on #1420: because of pypa/packaging-problems#870, we need a newer version of setuptools.
Nevertheless, pip
should handle this smoothly.
Pull Request Test Coverage Report for Build 14920294554Details
💛 - Coveralls |
I'm launching a test run just to confirm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lgtm, I didn't realize they added this feature (but I haven't been following the pypa specs very closely lately) but it seems quite handy.
Follow up of #1419
This leverage the brand new dependency group support introduced in pip 25.1 (https://pip.pypa.io/en/stable/user_guide/#dependency-groups). Notice that other tools we use like
nox
anduv
already support dependency groups.The main benefit of this PR is centralizing, again, the depedencies in
pyproject.toml
. Right now, some of the versions are pinned in GitHub Action files. Of course the old way works, but the new way is more aligned with what we do for tests and docs.note: #1420 is on hold until we merge this, I am making the
uv
PR leverage this.