Skip to content

Use dependency groups in CI #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 10, 2025
Merged

Conversation

IvanIsCoding
Copy link
Collaborator

@IvanIsCoding IvanIsCoding commented May 6, 2025

Follow up of #1419

This leverage the brand new dependency group support introduced in pip 25.1 (https://pip.pypa.io/en/stable/user_guide/#dependency-groups). Notice that other tools we use like nox and uv already support dependency groups.

The main benefit of this PR is centralizing, again, the depedencies in pyproject.toml. Right now, some of the versions are pinned in GitHub Action files. Of course the old way works, but the new way is more aligned with what we do for tests and docs.

note: #1420 is on hold until we merge this, I am making the uv PR leverage this.

@IvanIsCoding IvanIsCoding requested a review from mtreinish May 6, 2025 00:15
@IvanIsCoding IvanIsCoding added the dependencies Pull requests that update a dependency file label May 6, 2025
@@ -63,10 +63,13 @@ name = "Ivan Carvalho"
email = "[email protected]"

[build-system]
requires = ["setuptools>=70.1.0", "setuptools-rust>=1.9"]
requires = ["setuptools>=77.0.0", "setuptools-rust>=1.9"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something I overlooked on #1420: because of pypa/packaging-problems#870, we need a newer version of setuptools.

Nevertheless, pip should handle this smoothly.

@coveralls
Copy link

coveralls commented May 6, 2025

Pull Request Test Coverage Report for Build 14920294554

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.236%

Totals Coverage Status
Change from base Build 14916993103: 0.0%
Covered Lines: 18730
Relevant Lines: 19667

💛 - Coveralls

@IvanIsCoding
Copy link
Collaborator Author

I'm launching a test run just to confirm wheels.yml works: https://github.com/IvanIsCoding/rustworkx/actions/runs/14883616077. The test run excludes mac and QEMU to be cheaper on my end, but it will confirm the dependency groups work

Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lgtm, I didn't realize they added this feature (but I haven't been following the pypa specs very closely lately) but it seems quite handy.

@mtreinish mtreinish added this pull request to the merge queue May 10, 2025
Merged via the queue into Qiskit:main with commit 3fbc10d May 10, 2025
31 checks passed
@IvanIsCoding IvanIsCoding deleted the dependency-groups branch May 17, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants