Skip to content

Adding Fuzz targets for lr planar #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2025
Merged

Conversation

Krishn1412
Copy link
Contributor

Added a fuzz target to check the robustness of lr planar function.

Added a fuzz target to check the robustness of lr planar function.
@coveralls
Copy link

coveralls commented Apr 22, 2025

Pull Request Test Coverage Report for Build 15042146200

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.236%

Totals Coverage Status
Change from base Build 14945626099: 0.0%
Covered Lines: 18733
Relevant Lines: 19670

💛 - Coveralls

@Krishn1412
Copy link
Contributor Author

Hey @IvanIsCoding, could you take a look at this PR? TIA.

@IvanIsCoding
Copy link
Collaborator

@Krishn1412 I will take a look, but it seems that right now we are not asserting much about the function?

I need to check our source code if there are ways to panic. If there aren’t, I’m not sure how this fuzz will benefit us.

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll stand corrected, there are places our code could, in theory, panic:

I think we might be able to make it stronger but as is I think this should be fine.

A possible follow up is trying to generate random planar graphs and augmenting them to be non-planar.

@IvanIsCoding IvanIsCoding added this pull request to the merge queue May 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2025
@IvanIsCoding IvanIsCoding added this pull request to the merge queue May 17, 2025
Merged via the queue into Qiskit:main with commit 408397f May 17, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants