Skip to content

Make tox a nox shim and remove tox.ini #1431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,17 @@ rust code (or packaged python code) changes to the repo since then. Otherwise
the rustworkx package Nox installs in its virtualenv will be out of date (or
missing).

Note, if you run tests outside of Nox that you can **not** run the tests from
> [!NOTE]
> If you run tests outside of Nox that you can **not** run the tests from
the root of the repo, this is because rustworkx packaging shim will conflict
with imports from rustworkx the installed version of rustworkx (which contains
the compiled extension).


> [!NOTE]
> For compatibility purposes, rustworkx tests can also be run with `tox`.
Most commands should work by just replacing `nox` with `tox`.

#### Running tests with a specific Python version

If you want to run the tests with a specific version of Python, use the `test_with_version`
Expand Down
14 changes: 13 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,16 @@ environment = "MACOSX_DEPLOYMENT_TARGET=10.12"
repair-wheel-command = "brew install pipx && pipx ensurepath && pipx run --spec delocate==0.11.0 delocate-wheel --require-archs {delocate_archs} -w {dest_dir} -v {wheel} && pipx run abi3audit==0.0.9 --strict --report {wheel}"

[tool.cibuildwheel.windows]
repair-wheel-command = "cp {wheel} {dest_dir}/. && pipx run abi3audit==0.0.9 --strict --report {wheel}"
repair-wheel-command = "cp {wheel} {dest_dir}/. && pipx run abi3audit==0.0.9 --strict --report {wheel}"

[tool.tox]
legacy_tox_ini = """
[tox]
minversion = 4.4.0
envlist = py, lint, tests, docs, stubs, black

[testenv]
deps = nox
commands = nox -e {envname} -- {posargs}
skip_install = true
"""
93 changes: 0 additions & 93 deletions tox.ini

This file was deleted.