Small refactoring of unitary synthesis tests #13582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
ElePT
commented
Dec 19, 2024
| @@ -673,38 +569,6 @@ def test_coupling_map_transpile_with_backendv2(self, opt_level, bidirectional): | |||
| (0, 1), (circ_01_index[instr.qubits[0]], circ_01_index[instr.qubits[1]]) | |||
| ) | |||
|
|
|||
| @data(1, 2, 3) | |||
| def test_coupling_map_unequal_durations(self, opt): | |||
There was a problem hiding this comment.
I removed this test because we originally had it as the backend V1 version of test_coupling_unequal_duration_with_backendv2, it was then migrated to backend v2 and became essentially a duplicate of the other one.
Pull Request Test Coverage Report for Build 12412459848Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a small refactoring PR that proposes splitting the
UnitarySynthesistest class into two separate classes, one for tests that follow thebasis_gatespath, which is still in Python, and one for thetargetpath, which is now in Rust. With the current interleaving of target and basis gates tests it's easy to oversee what is covered where, and I believe that as a result we have an improvable coverage of both the Python and RustUnitarySynthesiscode. This PR doesn't fix that but sets the stage for reviewing and adding new tests in an organized way as we work on PRs like #13568.Details and comments
As I was moving the tests I took the time to squash a few of them into one, as they often just varied in one parameter that could be handled by ddt.