Import CircuitInstruction to fix Pylance complaint

[kevinsung]

Summary

Using CircuitInstruction in a type annotation causes Pylance to complain

Variable not allowed in type expression

This fixes that.

Details and comments

[qiskit-bot]

One or more of the following people are relevant to this code:

• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 12401989194

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• 13 unchanged lines in 3 files lost coverage.
• Overall coverage decreased (-0.008%) to 88.953%

---

Files with Coverage Reduction	New Missed Lines	%
crates/accelerate/src/unitary_synthesis.rs	1	92.2%
crates/qasm2/src/lex.rs	6	91.98%
crates/qasm2/src/parse.rs	6	97.62%

Totals
Change from base Build 12395850432:	-0.008%
Covered Lines:	79428
Relevant Lines:	89292

---

💛 - Coveralls

[Cryoris]

If we change this, it would be good to have a guideline and a check by CI/linter. Otherwise we cannot ensure we're consistent here and this change seems a bit arbitrary.

I've used Pylance as well, aren't there also other things it complains about? E.g. using (TypeA, TypeB) instead of tuple[TypeA, TypeB] or something?

[kevinsung]

If we change this, it would be good to have a guideline and a check by CI/linter. Otherwise we cannot ensure we're consistent here and this change seems a bit arbitrary.

Does the change still seem arbitrary after the latest commit? I think it brings it more in line with the rest of Qiskit, since we normally import stuff rather than setting a variable like it was before.

I've used Pylance as well, aren't there also other things it complains about? E.g. using (TypeA, TypeB) instead of tuple[TypeA, TypeB] or something?

I don't know, this is the only one that I noticed.