Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for macOS 10.12 from wheel build. #13561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinhartman
Copy link
Contributor

Summary

We'd originally expected to build wheels for x86_64 macOS 10.12 in #13470, but it turns out that macOS 13 cannot build anything older than 10.13:

Screenshot 2024-12-12 at 4 18 23 PM

The automatic bump-up to 11 on ARM is presumably something we expect. Correct me if I'm wrong.

Details and comments

This was noticed during the release of Qiskit 1.3.1.

Oddly, the wheel built for macOS ARM uses the bumped-up version of 11:

https://pypi.org/project/qiskit/#qiskit-1.3.1-cp39-abi3-macosx_11_0_arm64.whl

But the x86_64 wheel uses the version 10.12 (even though supposedly it would've been built for 10.13). I'm not sure what will happen, then, if this wheel gets pulled on macOS 10.12. Unfortunately, the included release note should be present in the 1.3.1 release, but is not. Perhaps we can add it manually.

https://pypi.org/project/qiskit/#qiskit-1.3.1-cp39-abi3-macosx_10_12_x86_64.whl

@kevinhartman kevinhartman requested a review from a team as a code owner December 12, 2024 22:20
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@jakelishman
Copy link
Member

There's a bit more info on why this happens here: #13503 (comment).

@kevinhartman
Copy link
Contributor Author

There's a bit more info on why this happens here: #13503 (comment).

@jakelishman thanks! Any idea why the wheel itself built with the 10.13 target still comes out as 10.12+ compatible? Will that actually work if someone running 10.12 pulls it down?

@jakelishman
Copy link
Member

I don't, unfortunately - it probably just still happens to only choose APIs that were still present in 10.12. Given that we have very little interaction with the OS from our extension modules, I wouldn't be surprised if our exposure is mostly just limited to the particular formats / initialisation routines in the dynamic libraries, and it's unlikely that macOS 10.13 completely overhauled everything, I guess?

@jakelishman
Copy link
Member

Or of course, it's not actually compatible with 10.12, and the audit tool just doesn't catch it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12305777620

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 21 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.941%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 3 91.73%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 12296775949: -0.02%
Covered Lines: 79408
Relevant Lines: 89282

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants