Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CXCancellation (deprecated in 1.1) #13426

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Nov 12, 2024

Summary

Follow up on #11937, this PR removes the pass CXCancellation, which it was deprecated in qiskit 1.1

@1ucian0 1ucian0 requested a review from a team as a code owner November 12, 2024 22:34
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@1ucian0 1ucian0 added this to the 2.0.0 milestone Nov 12, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11806894348

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 88.905%

Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/qasm2/src/lex.rs 2 92.73%
crates/qasm2/src/parse.rs 24 96.23%
Totals Coverage Status
Change from base Build 11803919642: -0.03%
Covered Lines: 79013
Relevant Lines: 88874

💛 - Coveralls

from test import QiskitTestCase # pylint: disable=wrong-import-order


class TestCXCancellation(QiskitTestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to move this test class to test_inverse_cancellation.py and modify the tests to use InverseCancellation([CXGate])?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. Done in fe0e44c . Thanks to that, I found this: #13437

@1ucian0 1ucian0 added the on hold Can not fix yet label Nov 14, 2024
@1ucian0
Copy link
Member Author

1ucian0 commented Nov 14, 2024

Tagging as blocked by #13437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold Can not fix yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants