Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new arithmetic gates to toctree #13418

Merged
merged 5 commits into from
Nov 13, 2024
Merged

Adding new arithmetic gates to toctree #13418

merged 5 commits into from
Nov 13, 2024

Conversation

alexanderivrii
Copy link
Contributor

Summary

Addresses #13407.

Should be backported to 1.3.

These fixes the docstrings for arithmetic gates and adds these gates to the toctree.

Details and comments

@alexanderivrii alexanderivrii added this to the 1.3.0 milestone Nov 10, 2024
@alexanderivrii alexanderivrii requested a review from a team as a code owner November 10, 2024 09:02
@qiskit-bot
Copy link
Collaborator

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@ShellyGarion ShellyGarion added the Changelog: None Do not include in changelog label Nov 10, 2024
@coveralls
Copy link

coveralls commented Nov 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11813020715

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 37 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.02%) to 88.909%
Files with Coverage Reduction New Missed Lines %
crates/accelerate/src/unitary_synthesis.rs 1 92.2%
crates/qasm2/src/expr.rs 1 94.02%
crates/qasm2/src/lex.rs 5 91.73%
qiskit/transpiler/passes/synthesis/high_level_synthesis.py 12 92.94%
crates/qasm2/src/parse.rs 18 96.69%
Totals Coverage Status
Change from base Build 11749692210: -0.02%
Covered Lines: 79042
Relevant Lines: 88902
💛 - Coveralls

@ShellyGarion
Copy link
Member

ShellyGarion commented Nov 10, 2024 •
edited
Loading

@alexanderivrii - thanks for preparing this PR!
I suggest to look carefully in the docs generated here, to see that no classes/functions in the circuit library were missed after all the updates done as part of #13046. I can't find here qaoa_ansatz from #13361

@mtreinish mtreinish added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 10, 2024
@ShellyGarion
Copy link
Member

ShellyGarion commented Nov 11, 2024 •
edited
Loading

I see that in the sections of "N-local circuits" and "Data encoding circuits" there are two different tables, one for functions and the other for BlueprintCircuits. However, in "Particular Quantum Circuits" there is a single table for functions and QuantumCircuits.
Should it be separated into two tables ?

Also: StatePreparation and Initialize are not BlueprintCircuits. Do they deserve their own section ?

@ShellyGarion
Copy link
Member

FullAdderGate doc does not look well:
image

@raynelfss raynelfss linked an issue Nov 12, 2024 that may be closed by this pull request
Add binary arithmetic gates to toctree #13407
Closed
@alexanderivrii
Copy link
Contributor Author

Addressing additional Shelly's comments in a4b551c: state preparation circuit should have their own paragraph (done) and the long table on particular quantum circuits should be split into two (done).

ShellyGarion
ShellyGarion approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@ShellyGarion ShellyGarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @alexanderivrii

@ShellyGarion ShellyGarion added this pull request to the merge queue Nov 13, 2024
Merged via the queue into Qiskit:main with commit 3a5257d Nov 13, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request Nov 13, 2024
@alexanderivrii @mergify
Adding new arithmetic gates to toctree (#13418)
3994c45 
* fixing docstrings of new adder gates and adding these gates to toctree

* move random_bitwise_xor to table

* adding qaoa to toctree

* adding missing parenthesis to docstring

* addressing Shelly's comments

---------

Co-authored-by: Julien Gacon <[email protected]>
(cherry picked from commit 3a5257d)
@mergify mergify bot mentioned this pull request Nov 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@mergify @alexanderivrii
Adding new arithmetic gates to toctree (#13418) (#13429)
2bf578e 
* fixing docstrings of new adder gates and adding these gates to toctree

* move random_bitwise_xor to table

* adding qaoa to toctree

* adding missing parenthesis to docstring

* addressing Shelly's comments

---------

Co-authored-by: Julien Gacon <[email protected]>
(cherry picked from commit 3a5257d)

Co-authored-by: Alexander Ivrii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShellyGarion ShellyGarion ShellyGarion approved these changes

Assignees

@ShellyGarion ShellyGarion

Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Add binary arithmetic gates to toctree
6 participants
@alexanderivrii @qiskit-bot @coveralls @ShellyGarion @mtreinish @Cryoris