Deprecate EchoRZXWeylDecomposition (Pulse)
#13366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One or more of the following people are relevant to this code:
|
ElePT
added
the
Changelog: Deprecation
eliarbel
approved these changes
Oct 24, 2024
| @@ -74,8 +74,11 @@ def test_rzx_number_native_weyl_decomposition(self): | |||
| circuit.cx(qr[0], qr[1]) | |||
|
|
|||
| unitary_circuit = qi.Operator(circuit).data | |||
|
|
|||
| after = EchoRZXWeylDecomposition(self.inst_map)(circuit) | |||
| with self.assertWarnsRegex( | |||
There was a problem hiding this comment.
In #13164 self.assertWarns was used almost everywhere in testing instead of self.assertWarnsRegex, in case you want uniformity in this aspect.
Pull Request Test Coverage Report for Build 11576798654Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #pulse, closes #12759.
EchoRZXWeylDecompositionrelies on the deprecated pulse functionality, so it should be deprecated with the rest of the package.Details and comments