Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip uninstallable tags in QPY backwards compatibility tests (backport #13202) #13217

Merged
merged 3 commits into from
Sep 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 24, 2024

Summary

When a tag has been made, but the package has not yet landed on PyPI, the QPY job fails in the environment-building step. This is not actually a failure of the QPY backwards-compatibility guarantees, and it isn't the job of the QPY tests to detect a bad tag anyway.

Details and comments

Since this commit is an acknowledgement that not every tag might be a valid version, and my editor was complaining about the safety of the various script calls, I made the variable expansion safe against word splitting, just in case.


This is an automatic backport of pull request #13202 done by [Mergify](https://mergify.com).

* Skip uninstallable tags in QPY backwards compatibility tests

When a tag has been made, but the package has not yet landed on PyPI,
the QPY job fails in the environment-building step.  This is not
actually a failure of the QPY backwards-compatibility guarantees, and
it isn't the job of the QPY tests to detect a bad tag anyway.

* Query PyPI to find versions to test

The logic we actually want for versions to test is "find the versions
that _should_ be installable", rather than "try it and see"; the latter
is susceptible to silently suppressing errors.  This new form now
queries PyPI to find what versions of Qiskit are available in binary
distributions for this platform, and filters based on that.

* Include release candidates in testing

(cherry picked from commit 1344cdd)

# Conflicts:
#	test/qpy_compat/process_version.sh
#	test/qpy_compat/run_tests.sh
@mergify mergify bot requested a review from a team as a code owner September 24, 2024 14:36
@mergify mergify bot added the conflicts used by mergify when there are conflicts in a port label Sep 24, 2024
Copy link
Contributor Author

mergify bot commented Sep 24, 2024

Cherry-pick of 1344cdd has failed:

On branch mergify/bp/stable/0.46/pr-13202
Your branch is up to date with 'origin/stable/0.46'.

You are currently cherry-picking commit 1344cddbe.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .azure/lint_docs_qpy-linux.yml
	deleted:    test/qpy_compat/compare_versions.py
	new file:   test/qpy_compat/get_versions.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/qpy_compat/process_version.sh
	both modified:   test/qpy_compat/run_tests.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish
  • @nkanazawa1989

@github-actions github-actions bot added type: qa Issues and PRs that relate to testing and code quality Changelog: None Do not include in changelog labels Sep 24, 2024
@coveralls
Copy link

coveralls commented Sep 24, 2024

Pull Request Test Coverage Report for Build 11027851929

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.01%) to 87.236%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 4 93.13%
Totals Coverage Status
Change from base Build 10965672707: 0.01%
Covered Lines: 74555
Relevant Lines: 85464

💛 - Coveralls

Copy link
Contributor

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ElePT ElePT added this pull request to the merge queue Sep 25, 2024
Merged via the queue into stable/0.46 with commit 41f1d20 Sep 25, 2024
11 checks passed
@1ucian0 1ucian0 added this to the 0.46.3 milestone Sep 25, 2024
@mtreinish mtreinish deleted the mergify/bp/stable/0.46/pr-13202 branch September 25, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog conflicts used by mergify when there are conflicts in a port type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants