-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump ahash from 0.8.6 to 0.8.11 #12154
Conversation
Bumps [ahash](https://github.com/tkaitchuck/ahash) from 0.8.6 to 0.8.11. - [Release notes](https://github.com/tkaitchuck/ahash/releases) - [Commits](https://github.com/tkaitchuck/ahash/commits/v0.8.11) --- updated-dependencies: - dependency-name: ahash dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the the following people are requested to review this:
|
Okey dokey, after some dancing on the bottom of #11510, this should have been a successful way of cancelling the "ignore" command we issued to dependabot, since ahash did apparently decide to roll back the huge MSRV bump eventually. I'm still nervous because as a project, ahash does not appear to be very concerned with stability guarantees (see the response to #216, and how the huge bump to MSRV 1.72 from 1.60 was considered eligible for a patch release), but hopefully this is good enough for now. We need updated ahash to get Miri working. I'll push a test wheel-build commit to trial this. |
Whoops, I removed the deployment bit but forgot to remove the environment request. |
7f8a6ce
to
c8beda5
Compare
Pull Request Test Coverage Report for Build 8597314613Details
💛 - Coveralls |
5bcd8aa
to
1197e3a
Compare
1197e3a
to
61b473b
Compare
Ok, https://github.com/Qiskit/qiskit/actions/runs/8596576569/job/23553439088?pr=12154 shows a complete wheel-build run (including dummy commit 1197e3a) for all relevant targets ignoring the win32 fail - it's got the same trouble encountered in #11267 when setting rustc to 1.70, but I can't be bothered to debug that since it's irrelevant to our CD. The important thing is that Linux AArch64 passed. With that in place, I'll merge this and we should be safe to continue upgrading aHash (until the next time they decide to make a huge MSRV jump in a patch release). |
Bumps ahash from 0.8.6 to 0.8.11.
Release notes
Sourced from ahash's releases.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)