Improve performance of basis_gates path

This commit improves the performance of the basis_gates code path by combining the basis_gates set with the built-in directives and doing only one set lookup per iteration instead of two. Co-authored-by: John Lapeyre <[email protected]>
Qiskit · Jan 20, 2022 · 557362f · 557362f
1 parent 9f9c935
commit 557362f
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/qiskit/transpiler/passes/utils/gates_basis.py b/qiskit/transpiler/passes/utils/gates_basis.py
@@ -36,7 +36,9 @@ def __init__(self, basis_gates=None, target=None):
                 "A value for 'basis_gates' or 'target' must be set to use this pass"
             )
         if basis_gates is not None:
-            self._basis_gates = set(basis_gates)
+            self._basis_gates = set(basis_gates).union(
+                {"measure", "reset", "barrier", "snapshot", "delay"}
+            )
         self._target = target
 
     def run(self, dag):
@@ -55,9 +57,8 @@ def run(self, dag):
                     gates_out_of_basis = True
                     break
         else:
-            basic_instrs = {"measure", "reset", "barrier", "snapshot", "delay"}
             for gate in dag._op_names:
-                if gate not in self._basis_gates and gate not in basic_instrs:
+                if gate not in self._basis_gates:
                     gates_out_of_basis = True
                     break
         self.property_set["all_gates_in_basis"] = not gates_out_of_basis