Extended rzz validation to include parameter expressions

[yaelbh]

Summary

Details and comments

Fixes #2067

[wshanks]

This looks good to me.

I think a release note would be good since it is a user-facing change (in the sense of the user getting an error in the client instead of an error from the service after a bad parameter binding).

I was not familiar with the internals of the Pub classes before so reading this code I was concerned about whether it handled multiple dimensions correctly. I added some dimensions to the tests and confirmed that it did.

The part that made me worried about dimensions (not being that familiar with the pub classes) was the relationship between list(chain.from_iterable(pub.parameter_values.data)) and pub.parameter_values.ravel().as_array(). It might be nice if the pub class had a parameter_names property that was a shorthand for the first expression and if as_array documented that its columns matched parameter_names when its parameters argument was not used so that the connection was more clear.

[yaelbh]

@wshanks Thanks for the review!
For your suggestions related to parameter names in BindingsArray I've opened an issue in qiskit: Qiskit/qiskit#13691.
I also added a release note, @wshanks or @kt474 can you please check if the note is clear, before I merge?

[wshanks]

The note looks clear to me. 👍