Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.5.0 release #19

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Prepare for 0.5.0 release #19

merged 2 commits into from
Nov 12, 2024

Conversation

ajbozarth
Copy link
Collaborator

@ajbozarth ajbozarth commented Nov 12, 2024

Updates to 0.5.0 and include bug fixes associated with the merger of local mode and feedback code

Included bug fixes:

  • Updates API endpoints
    • Adds is_openai to /service return
    • Removes 501 returns for disclaimer endpoints and instead returns "successful" values
    • Adds is_openai case to feedback endpoint that returns an "unsupported" message
  • Adds a helper function to wipe lastPrompt value when the value becomes irrelevant
  • Updates model dropdown list to remember the current model and wipes the lastPrompt value on model update
  • Saves the is_openai value when the service url is set and only shows the feedback UI when is_openai is false

Weird UI edge case:
The feedback buttons are not immediately removed when the service UI is switch to an OpenAI one. The status bar is updated when you change tabs and the notebook cell toolbar is updated either when switching cells or running a completion. This is not an issue though since if the user tries to use the feedback during this edge case they will see a "unsupported" notification.

Also includes various bug fixes
@ajbozarth ajbozarth added bug Something isn't working maintenance labels Nov 12, 2024
@ajbozarth ajbozarth self-assigned this Nov 12, 2024
@ajbozarth ajbozarth marked this pull request as ready for review November 12, 2024 01:21
Copy link
Member

@cbjuan cbjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, I tested the new wheel and it works as described

@ajbozarth ajbozarth merged commit 912e8f1 into main Nov 12, 2024
7 checks passed
@ajbozarth ajbozarth deleted the 05 branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants