Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Jupyterlab 4.3 and fix prompt accept bug #13

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Update to Jupyterlab 4.3 and fix prompt accept bug #13

merged 2 commits into from
Oct 30, 2024

Conversation

ajbozarth
Copy link
Collaborator

This updates to Jupyterlab 4.3 and includes the fix for the postModelPromptAccept edge case.

Fixes #1

This updates to Jupyterlab 4.3 rc0 and includes the fix for the
`postModelPromptAccept` edge case

Fixes #1
@ajbozarth ajbozarth added the bug Something isn't working label Oct 17, 2024
@ajbozarth ajbozarth self-assigned this Oct 17, 2024
@ajbozarth
Copy link
Collaborator Author

This draft PR is based on rc0 for early testing, it will be updated and taken out of draft once 4.3 is released

Copy link
Member

@cbjuan cbjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Let's wait to see when the final 4.3.0 gets released

@ajbozarth ajbozarth marked this pull request as ready for review October 30, 2024 17:42
@ajbozarth ajbozarth requested a review from vabarbosa as a code owner October 30, 2024 17:42
@ajbozarth
Copy link
Collaborator Author

Jupyterlab 4.3 was release, so I've updated this and moved it out of draft

@ajbozarth ajbozarth requested review from cbjuan and removed request for cbjuan October 30, 2024 17:44
@ajbozarth ajbozarth merged commit 84ceea3 into main Oct 30, 2024
6 checks passed
@ajbozarth ajbozarth deleted the lab43 branch October 30, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

postModelPromptAccept is not always called when using "Tab" completer
2 participants