Fix broken CI #210
Merged
Fix broken CI #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaucasau
changed the title
bind_parameters() call for assign_parameters()
arnaucasau
changed the title
bind_parameters() call for assign_parameters()
mtreinish
approved these changes
Apr 11, 2024
| @@ -1,6 +1,6 @@ | |||
| qiskit-aer>=0.13 | |||
| pytest | |||
| pylint==2.16.2 | |||
There was a problem hiding this comment.
I worry this might be too loose for pylint which notoriously has had issues with rule stability between even on bugfix releases. But lets give it a try and we can do an exact version pin if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI was broken for four reasons:
pylintwas pinned to version 2.16.2 which doesn't support Python 3.12 and 3.11 officiallyimplibrary in favor ofimportliband we were using a version ofipykernalthat was importing the old library. The PR pinsipykernalto the first version supportingimportlib. See this issue.bind_parametersforassign_parametersas explained in the qiskit 1.0 release notes.qiskit.executefunction is not available in Qiskit 1.0 anymore -> Migration guide