refactor: align the keep_only_odd logic between backends
#55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than having the `.terms` of the `LayerModel` report confusing values, this refactors the internal workings of this method to be in-line with the tenpy-based implementation. This also removes an unnecessary factor of 2.0 in the Rz gate conversion. In doing so, this commit ensures that the reported Hamiltonian interactions terms are compatible between the quimb- and tenpy-based implementations.
Pull Request Test Coverage Report for Build 13054286509Details
💛 - Coveralls |
mrossinek
changed the title
keep_only_odd logic between backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aligns the internal handling of the
keep_only_oddlogic to be identical between the tenpy- and quimb-based backend. This guarantees that theLayerModelimplementations for each backend report the same bond interaction Hamiltonians, ensuring a consistent user experience.In doing so, the
keep_only_oddattribute of quimb'sLayerModelclass has been removed, as it is now entirely processed during theLayerModel.from_quantum_circuitconstruction.Furthermore, the
scaling_factorarguments of theLayerModel.from_quantum_circuitconstructors actually became redundant due to this change, which is why they are also being removed.