Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make isDigitalPinValid() accept pin array #1

Closed
DreiDe opened this issue Apr 8, 2022 · 2 comments · Fixed by #3
Closed

Make isDigitalPinValid() accept pin array #1

DreiDe opened this issue Apr 8, 2022 · 2 comments · Fixed by #3
Assignees
Labels
enhancement New feature or request

Comments

@DreiDe
Copy link
Contributor

DreiDe commented Apr 8, 2022

To avoid such big cluttered structures:
image

it would be nice if an array of integers representing the pins could be directly passed to the isDigitalPinValid.

Therefore I would recommend to use a function overload so we can keep backwards compatibility and easy access with just one Pin passed to the function.

@DreiDe DreiDe added the enhancement New feature or request label Apr 8, 2022
@happybrick
Copy link
Contributor

@DreiDe Added bool isDigitalPinsValid(uint8_t pins[], uint16_t pinsLength);

See ec9fbbc

@happybrick happybrick assigned DreiDe and unassigned happybrick May 9, 2022
@DreiDe
Copy link
Contributor Author

DreiDe commented May 10, 2022

@happybrick
Whoops, this one got lost somewhere in my emails, although I got notified by the mention before.

Please also open a PR for this one. They get extra attention in my inbox 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants