vehicleshop stable version

[Frowmza]

Description

• Overall code improvements
• Use qbx_vehicles API (need 21)
• Fix test drive
• Add statebag isInTestDrive to check if player is in test drive

Checklist

• I have personally loaded this code into an updated Qbox project and checked all of its functionality.
• My pull request fits the contribution guidelines & code conventions.

[Manason]

Where are the changes to qbx_vehicles being used in this PR?

[Frowmza]

is this good?, i removed plate from filters in qbx_vehicles here

[Frowmza]

as for createPlayerVehicle, should make it return generated plate, i think it would be best approach

local function createPlayerVehicle(request)
    assert(request.model ~= nil, 'missing required field: model')

    local props = request.props or {}
    if not props.plate then
        repeat
            props.plate = qbx.generateRandomPlate()
        until doesEntityPlateExist(props.plate) == false
    end
    props.engineHealth = props.engineHealth or 1000
    props.bodyHealth = props.bodyHealth or 1000
    props.fuelLevel = props.fuelLevel or 100
    props.model = joaat(request.model)

    if not triggerEventHooks('createPlayerVehicle', { citizenid = request.citizenid, garage = request.garage, props = props }) then
        return nil, {
            code = 'hook_cancelled',
            message = 'a createPlayerVehicle event hook cancelled this operation'
        }
    end

    local vehicleId = MySQL.insert.await('INSERT INTO player_vehicles (license, citizenid, vehicle, hash, mods, plate, state, garage) VALUES ((SELECT license FROM players WHERE citizenid = @citizenid), @citizenid, @vehicle, @hash, @mods, @plate, @state, @garage)', {
        citizenid = request.citizenid,
        vehicle = request.model,
        hash = props.model,
        mods = json.encode(props),
        plate = props.plate,
        state = request.garage and State.GARAGED or State.OUT,
        garage = request.garage
    })

    return {
        vehicleId = vehicleId,
        plate = props.plate
    }
    
    -- or this so we dont need to make changes where this function is used in any other resource
    -- return vehicleId, props.plate
end

[Frowmza]

this tested and ready for a review!