Fixing errors caused by new core #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated config - Updated client/main - Updated locales
- Adjusted names - Adjusted garage for vehicles - Added function to spawn helicopter - Added ability to turn on/off blip - Hopefully fixed some linter errors
- Added missing helicopter teleport - Added locales - Minor refactoring
|
Tested these fixes on live server, it seems to fix the job and make it work with Qbox. However, the resource itself seems lackluster/lacking in design. Maybe potential for reworking slightly? |
3 tasks
Manason
requested changes
Nov 24, 2023
|
I do agree with both of you, this does actually need a good rewrite, but with this PR I just wanted to convert it and make it usable, before doing the actual rewrite to make it better. |
Manason
approved these changes
Nov 25, 2023
mafewtm
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was an issue when you started a resource about core objects, so this fixes it, I also moved the config to a folder and adjusted the code a little bit to match the new format and more user-friendly names.
There is still an error for the camera.lua file, I was unable to determine what's causing it, so if someone can point me in the right direction, I will be more than happy to fix that issue too.
Checklist