Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use vehicleId instead of plate when checking ownership #50

Merged
merged 3 commits into from
May 5, 2024
Merged

refactor: use vehicleId instead of plate when checking ownership #50

merged 3 commits into from
May 5, 2024

Conversation

Manason
Copy link
Contributor

@Manason Manason commented May 5, 2024

  • renamed checkOwnership to isParkable
  • use vehicleId instead of plate to lookup vehicles
  • minimize query size
  • avoid player query, instead opting to use the player object from core to get the player's gang.

@KostaZx KostaZx merged commit d16efc2 into main May 5, 2024
4 checks passed
@Manason Manason deleted the parkable-refactor branch May 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KostaZx KostaZx KostaZx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manason @KostaZx