Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: outside vehicles tracking vehicle id #45

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Manason
Copy link
Contributor

@Manason Manason commented Apr 29, 2024

  • merged some functions instead of multiple events/callback occurring when a vehicle is parked
  • moved the actual entity deletion to the server side
  • restructured and renamed checkPlayers to kickOutPeds, although I wonder if this is even needed.
  • adding server side state bag to vehicles to store the vehicle id. This is the unique database column identifying owned vehicles. Switching the ownedVehicles checker to use this as the id instead of plate. Future PRs will shift away from using plate as an identifier for a vehicle, since a plate could change. We should be using vehicle id as the primary id of vehicles.

@KostaZx KostaZx merged commit df49c1b into main Apr 29, 2024
4 checks passed
@Manason Manason deleted the refactor-outside-vehicles branch April 29, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants