Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(client/main): fix structure and move config out of client lua #2

Merged
merged 2 commits into from
Jul 10, 2024
Merged

refactor(client/main): fix structure and move config out of client lua #2

merged 2 commits into from
Jul 10, 2024

Conversation

solareon
Copy link
Contributor

Description

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

Manason
Manason approved these changes Jul 10, 2024
View reviewed changes
config/client.lua Outdated Show resolved Hide resolved
config/client.lua
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These could benefit from explanation comments. peds/scenario can be a bit confusing.

client/main.lua Show resolved Hide resolved
@solareon solareon merged commit 58bc357 into main Jul 10, 2024
4 checks passed
@solareon solareon deleted the release-changes branch July 10, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manason Manason Manason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solareon @Manason