-
Notifications
You must be signed in to change notification settings - Fork 190
Optimization: Update Player Data When Key Change #663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, optimized and better trafic
My PR #661 will change a lot of how player data is saved and updated inside the core. You should wait until that one is merged and adjust this one. |
The blocker for this PR was closed, this can probably be something that can be considered for merging now. |
I've implemented these changes on my server, and the PR itself works fine, however, some external resources use |
Thanks for testing it out! The issue seems to stem from external resources using if source == '' then return end, which now blocks QBCore:Player:SetPlayerData. If those resources are not escrowed, they should be able to adjust their validation to accommodate this change. |
Description
This change is to update player data when the key of data changing, so we can reduce the traffic from server to client.
Also i tested it for qb-core compat.
Checklist