Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(client): move nationalities #591

Merged
merged 2 commits into from
Oct 4, 2024
Merged

refactor(client): move nationalities #591

merged 2 commits into from
Oct 4, 2024

Conversation

mafewtm
Copy link
Member

@mafewtm mafewtm commented Oct 4, 2024

Description

Moves the nationalities out of config/client.lua to data/nationalities.lua in order to better organize and prevent the client config from being too long.

I think lib.load is correct for this. If I'm wrong, let me know.

Checklist

  • I have personally loaded this code into an updated Qbox project and checked all of its functionality.
  • My pull request fits the contribution guidelines & code conventions.

@solareon solareon merged commit d318d0f into main Oct 4, 2024
4 checks passed
@solareon solareon deleted the move-nationalities branch October 4, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants