SDL: Default to no keyboard grab on Windows. #831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the default on Linux, and incidentally used to be the default on Windows as well, until vcpkg got introduced which brought a modern SDL version with support for keyboard grabbing.
|
This commit is switching it to 1 instead of CVAR_DEF2 which is 0 in linux/bsd and 1 for "other", don't you just want to add windows to that list (or just change the default to 0)? In which case we can remove CVAR_DEF2 as that's all it's for, turning keyboard grabbing on in windows by default. |
|
It was a test of reviewers! 😂 |
dsvensson
force-pushed
the
no-keyboard-grab
branch
from
46829fb
to
964a0ed
Compare
|
But you are right, not sure what the implications are on macOS. I'll add Windows to the ifdef for now. Update: No, that breaks mouse grabbing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the default on Linux, and incidentally used to be the default on Windows as well, until vcpkg got introduced which brought a modern SDL version with support for keyboard grabbing.
Fixes #830