Step 4: Refactor Orchard structures to generics and add Orchard ZSA support for Transaction V6 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(without unit tests fixing for now). - Refactored `ShieldedData` and `Action` structures to be generics parameterized by Orchard flavor (`OrchardVanilla` or `OrchardZSA`), enabling support for both Orchard protocols in Tx V6. - Introduced a `burn` field in `ShieldedData` to support ZSA, with unit type for Tx V5 and a vector of burn items for Tx V6. - Modified `Transaction` enum methods (orchard_...) to handle generics properly, ensuring compatibility with both Orchard flavors. - Implemented serialization and deserialization for Tx V6 while avoiding code redundancy with Tx V5 wherever possible.
…m/QED-it/zebra into switch-to-zsa-crates-nu6-txv6-gen
… with the upstream halo2/librustcash/orchard/sapling versions
…-zsa-crates-nu6-txv6-gen
…witch-to-zsa-crates-nu6-txv6-gen
dmidem
changed the title
|
Closed in favour of #17 due to the branch renaming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Orchard-related structures to be generics and adds support for both Orchard Vanilla and Orchard ZSA in Zebra's Transaction V6. This change allows the codebase to handle both versions of the Orchard protocol and implements necessary serialization/deserialization logic.
Key changes
ShieldedDataandActionstructures to be generic, parameterized by Orchard flavor (OrchardVanillaorOrchardZSA), enabling support for both protocols in Tx V6.burnField inShieldedData:burnfield toShieldedDatato support ZSA: a unit type for Tx V5 and a vector of burn items for Tx V6.TransactionEnum Methods:Transactionenum to handle the new generic structures properly and support both Orchard flavors.