Check recipient address #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uribrecher
reviewed
Feb 6, 2022
| - Copy the `.metamaskrc.dist` file to `.metamaskrc` | ||
| - Replace the `INFURA_PROJECT_ID` value with your own personal [Infura Project ID](https://infura.io/docs). | ||
| - If debugging MetaMetrics, you'll need to add a value for `SEGMENT_WRITE_KEY` [Segment write key](https://segment.com/docs/connections/find-writekey/). | ||
| - Run `git update-index --skip-worktree qedit.env.js` to prevent env file from being tracked by git |
| @@ -60,7 +60,8 @@ function defineAndRunBuildTasks() { | |||
| skipStats, | |||
| } = parseArgv(); | |||
|
|
|||
| const browserPlatforms = ['firefox', 'chrome', 'brave', 'opera']; | |||
| // const browserPlatforms = ['firefox', 'chrome', 'brave', 'opera']; | |||
| const browserPlatforms = ['chrome']; | |||
There was a problem hiding this comment.
do we want this as part of our pull request to the original metamask repo?
from what I understand this is just to reduce the work of the hot-reload right?
| @@ -38,6 +40,11 @@ export default class SendContent extends Component { | |||
| asset: PropTypes.object, | |||
| to: PropTypes.string, | |||
| assetError: PropTypes.string, | |||
| recipient: PropTypes.shape({ | |||
There was a problem hiding this comment.
can you please explain this PropTypes.shape thing to me?
| @@ -1585,6 +1609,7 @@ export function updateRecipient({ address, nickname }) { | |||
| nickname: nickname || nicknameFromAddressBookEntryOrAccountName, | |||
| }), | |||
| ); | |||
| await dispatch(qeditSecurityCheckStatus()); | |||
There was a problem hiding this comment.
not sure I understand this, would love to sit with you so that you explain to me this part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #
Explanation:
Manual testing steps: