Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize backward-compatible Orchard crate #52

Open
wants to merge 3 commits into
base: zcash-tx-test-tool-txv5
Choose a base branch
from

Conversation

dmidem
Copy link
Collaborator

@dmidem dmidem commented Mar 5, 2024

This pull request aims to update librustzcash to utilize the modified, backward-compatible orchard crate. The previous version of the orchard crate used in librustzcash exclusively supported the Vanilla variant of the Orchard protocol. However, recent modifications have introduced generics to orchard fork, enabling it to support both Vanilla and ZSA variants.

Modifications include:

  • Updated the zcash_primitives and zcash_client_backend crates within librustzcash to use the modified version of the orchard crate.
  • Modified unit tests within librustzcash to use the updated orchard crate.

Further modifications are required to fully leverage the capabilities of the Orchard ZSA variant.

…te (which supports Vanilla and ZSA) - but for now zcash_primitives is not generalised itself and pinned to Vanilla only
@QED-it QED-it deleted a comment from what-the-diff bot Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant