-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies update 10 sep 2024 #78
base: main
Are you sure you want to change the base?
Conversation
Bumps `mockkAndroid` from 1.13.9 to 1.13.12. Updates `io.mockk:mockk-agent` from 1.13.9 to 1.13.12 - [Release notes](https://github.com/mockk/mockk/releases) - [Commits](mockk/mockk@1.13.9...1.13.12) Updates `io.mockk:mockk-android` from 1.13.9 to 1.13.12 - [Release notes](https://github.com/mockk/mockk/releases) - [Commits](mockk/mockk@1.13.9...1.13.12) --- updated-dependencies: - dependency-name: io.mockk:mockk-agent dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: io.mockk:mockk-android dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nl.littlerobots.version-catalog-update](https://github.com/littlerobots/version-catalog-update-plugin) from 0.8.1 to 0.8.4. - [Release notes](https://github.com/littlerobots/version-catalog-update-plugin/releases) - [Changelog](https://github.com/littlerobots/version-catalog-update-plugin/blob/main/CHANGELOG.md) - [Commits](littlerobots/version-catalog-update-plugin@v0.8.1...v0.8.4) --- updated-dependencies: - dependency-name: nl.littlerobots.version-catalog-update dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps `kotlin` from 2.0.10 to 2.0.20. Updates `org.jetbrains.kotlin.plugin.serialization` from 2.0.10 to 2.0.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v2.0.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.0.10...v2.0.20) Updates `org.jetbrains.kotlin.android` from 2.0.10 to 2.0.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v2.0.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.0.10...v2.0.20) Updates `org.jetbrains.kotlin.plugin.compose` from 2.0.10 to 2.0.20 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v2.0.20/ChangeLog.md) - [Commits](JetBrains/kotlin@v2.0.10...v2.0.20) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.plugin.serialization dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin.android dependency-type: direct:production update-type: version-update:semver-patch - dependency-name: org.jetbrains.kotlin.plugin.compose dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
…encies-update-10-sep-2024
…ockkAndroid-1.13.12' into dependencies-update-10-sep-2024
…l.littlerobots.version-catalog-update-0.8.4' into dependencies-update-10-sep-2024 # Conflicts: # gradle/libs.versions.toml
and gradle to 8.6.0
kotlin = "2.0.20" | ||
# should match kotlin https://github.com/google/ksp/releases | ||
ksp = "2.0.20-1.0.25" | ||
gradlePlugin = "8.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gradle plugin version 8.6.0 seems to require java version 22, which does not match our target compatibility of 21. Also our self-hosted runner seems to be running java_22 which is recommended by this template. So before merging, it seems we should either update the runner to support 22 and change the targetcompatibility to 22...
or revert this gradle version change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all of the above, I hardly know what I'm talking about
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update: even without this change; the self-hosted build fails, this change may not be the cause and could actually be fine #79
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are still using gradle 8.7 so it might be that we need to bump that:
https://github.com/Q42/Template.Android/blob/main/gradle/wrapper/gradle-wrapper.properties
when you say "self-hosted runner" what are you referring to? i see the github action to be passing
regardless agp
8.6.1 has been released so we could try that too :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🆙
firebaseBOM = "33.1.2" | ||
manesVersions = "0.44.0" | ||
littleRobotsCatalogUpdates = "0.8.1" | ||
firebaseBOM = "33.2.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the 33.3.0
has already been released: https://firebase.google.com/support/release-notes/android#2024-09-12
hilt = "2.52" | ||
retrofit = "2.11.0" | ||
kotlinx-serialization = "1.6.3" | ||
kotlinx-serialization = "1.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.7.3
has been released: https://github.com/Kotlin/kotlinx.serialization/releases
retrofit2KotlinxSerializationConverter = "1.0.0" | ||
networkResponseAdapter = "5.0.0" | ||
napier = "2.7.1" | ||
composeDestinations = "1.10.2" | ||
okhttp = "4.12.0" | ||
composePlatform = "2024.08.00" | ||
activityCompose = "1.9.1" | ||
composePlatform = "2024.09.00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
compose bom 2024.09.02
has already been released: https://developer.android.com/develop/ui/compose/bom/bom-mapping
hiltNavigationCompose = "1.2.0" | ||
composeLifecycle = "2.8.4" | ||
composeLifecycle = "2.8.5" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2.8.6
has already been released: https://developer.android.com/jetpack/androidx/releases/lifecycle
Why is this important?
Notes