Support Swift 6 language mode #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Make models conform to Sendable * Remove private static 'shared' property because it was not used * Mark collection methods as @mainactor
* Update to modern Xcode project settings * Enable Swift 6.0 language mode
edwinveger
reviewed
Mar 6, 2025
Sources/Q42Stats/Q42Stats.swift
Outdated
| DispatchQueue.main.async { | ||
| self._log(key: "Watch_paired", value: session.isPaired.description) | ||
| } | ||
| self._log(key: "Watch_paired", value: session.isPaired.description) |
There was a problem hiding this comment.
How do we guarantee self._log( is only accessed from the same thread?
- Could we make
Q42Statsan actor to isolate access tovar collected: [String: String]?
That'd interfere with theWCSessionDelegateconformance though… - Or wrap it in some
Box<T>?
actor Box<T: Sendable> {
private var value: T
init(_ value: T) {
self.value = value
}
func get() -> T {
return value
}
func set(_ newValue: T) {
value = newValue
}
}- Or just mark the property
@MainActor🤷🏻♂️
There was a problem hiding this comment.
Marking it as @MainActor would have my preference since it's the simplest :)
|
By the way, we probably should update |
|
That might break older project which aren't on Swift 6 yet. Since it's only the minimum tools version, we can leave it for now |
edwinveger
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
Support Swift 6 language mode
Update Demo app to modern settings