BUGFIX extremely broad proguard rules were exposed to consumer

Which ballooned app sizes for apps implementing this lib
Q42 · Jul 11, 2022 · 67e1be4 · 67e1be4
1 parent 934d3f5
commit 67e1be4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 87 deletions.
diff --git a/q42stats/build.gradle b/q42stats/build.gradle
@@ -17,17 +17,16 @@ android {
 
         buildConfigField("String", "LIB_BUILD_DATE", '"' + new SimpleDateFormat("yyyy-MM-dd").format(Calendar.getInstance().getTime()) + '"')
 
-        proguardFiles getDefaultProguardFile('proguard-android-optimize.txt'), 'proguard-rules.pro'
-
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         consumerProguardFiles "consumer-rules.pro"
     }
 
     buildTypes {
         release {
-            minifyEnabled true
-            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
-            consumerProguardFiles 'proguard-rules.pro'
+            minifyEnabled false
+            // we don't want to minify the library, that's the consumer (implementing app)'s job
+            consumerProguardFiles 'consumer-rules.pro'
+            // will be copied into implementing app's proguard files
         }
     }
     compileOptions {

diff --git a/q42stats/proguard-rules.pro b/q42stats/proguard-rules.pro