Add property to calculate and expose next run time of routine. #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillymosh
reviewed
Jul 27, 2024
adambirds
force-pushed
the
next_run_routine
branch
from
ea35ab5 to
fed7b25
Compare
|
Is this able to be merged now? I have had this running for a few weeks now without an issue by installing direct from my branch but would be good to get merged. |
|
@chillymosh can this be merged? |
I will test it now |
|
Ideally this would be a method, not a property. Logic after some testing works fine though |
EvieePy
requested changes
Sep 1, 2024
| @@ -330,6 +330,22 @@ def start_time(self) -> Optional[datetime.datetime]: | |||
| """ | |||
| return self._start_time | |||
|
|
|||
| @property | |||
| def next_run(self) -> Optional[datetime.datetime]: | |||
There was a problem hiding this comment.
Not sure why it's optional? It doesn't appear the return would ever be optional
| if next_run < now: | ||
| next_run = now + datetime.timedelta(seconds=self._delta) | ||
|
|
||
| return next_run |
There was a problem hiding this comment.
I'll have to check but this looks like it may have potential for next_run to never be defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a property
next_runthat calculates the next run time for the routine to the Routine class so that this can be exposed and used in other commands etc.I have tested this on my own production twitch bot by installing from git and it works great.
Checklist