-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add matrix checker page, exercises x users per course #351
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
fc54392
feat: Add matrix checker page, exercises x users per course
yammesicka ec2a82d
chore: Merging from master
yammesicka 6945390
dev: Add tool to update i18n
yammesicka 09a66c1
chore: Small formatting fixes
yammesicka e5666b5
feat: Complete feature, now just add tests
yammesicka de0fea3
fix: Remove prints for line (")O_o(")
yammesicka 0f29545
fix: Linter
yammesicka 3908869
tests: Add tests for solution matrix
yammesicka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,18 @@ | ||
#!/bin/bash -x | ||
|
||
SCRIPT_FILE_PATH=$(readlink -f "${0}") | ||
SCRIPT_FOLDER=$(dirname "${SCRIPT_FILE_PATH}") | ||
MAIN_FOLDER="${SCRIPT_FOLDER}/.." | ||
original_dir="$(pwd)" | ||
|
||
cd "$(dirname "${0:-${BASH_SOURCE[0]}}")" || return | ||
cd .. | ||
|
||
|
||
if [ "${1}" = "update" ]; then | ||
echo "Updating translations" | ||
pybabel extract -F "lms/babel.cfg" -o "lms/lmsweb/translations/messages.pot" "lms" | ||
pybabel update -i "lms/lmsweb/translations/messages.pot" -d "lms/lmsweb/translations" | ||
fi | ||
|
||
echo "Compiling Flask Babel" | ||
pybabel compile -d "${MAIN_FOLDER}/lms/lmsweb/translations" | ||
pybabel compile -d "lms/lmsweb/translations" | ||
|
||
cd "$original_dir" || return |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -141,7 +141,7 @@ def _handle_failed_to_execute_tests(self, raw_results: bytes) -> None: | |
solution=self._solution, | ||
test_name=models.ExerciseTestName.FATAL_TEST_NAME, | ||
user_message=fail_user_message, | ||
staff_message=_('Bro, did you check your code?'), | ||
staff_message=_('Woah! Did you check your code?'), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. suggestion (code_refinement): Consider the tone of user-facing messages. While the change in message tone to be more informal might be intended to be friendly, ensure it aligns with the overall tone and user experience of the application. |
||
) | ||
notifications.send( | ||
kind=notifications.NotificationKind.UNITTEST_ERROR, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
SOLUTIONS = '/view' | ||
STATUS = '/status' | ||
SUBMISSIONS = '/submissions' | ||
DOWNLOADS = '/download' | ||
SHARED = '/shared' | ||
GIT = '/git/<int:course_id>/<int:exercise_number>.git' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider optimizing the query for
get_students
.This method could potentially return a large number of records. Consider adding pagination or limiting the number of records returned.